Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the test listener interface to ensure that implementations are read-only #2477

Closed
sebastianbergmann opened this issue Feb 6, 2017 · 6 comments

Comments

@sebastianbergmann
Copy link
Owner

No description provided.

@padraic
Copy link

padraic commented Apr 26, 2017

Just a quick question. Can we assume that this level of write access would have a replacement prior to this change? Something that can be injected in, as opposed to requiring user-level editing of tests?

@sebastianbergmann
Copy link
Owner Author

The whole point of this is to get rid of write access. A listener should only listen, not change things around.

What kind of write access do you need, @padraic?

@padraic
Copy link

padraic commented Apr 26, 2017

Essentially, we're doing some basic performance management applied to mutation testing: ordering test suites by execution time (though at the individual test level is beyond our current capabilities if I recall), and some test suite elimination where not relevant to a "mutated line". We can end up doing this hundreds of times (i.e. we can literally run phpunit hundreds of times), so the benefits are unique but extremely advantageous to that sort of batch running of phpunit. Hopefully that makes sense in that we wouldn't have any access per se to how the tests are written - we're just executing phpunit with some minor manipulation.

@sebastianbergmann
Copy link
Owner Author

Can you please open a feature request ticket for an extension point to sort PHPUnit\Framework\TestSuite before test execution starts? Thanks!

@padraic
Copy link

padraic commented Apr 26, 2017

I will do @sebastianbergmann

@sebastianbergmann
Copy link
Owner Author

The TestListener interface will be deprecated (#3388) and removed (#3389) so there is no need for this.

@sebastianbergmann sebastianbergmann removed their assignment Nov 8, 2018
@sebastianbergmann sebastianbergmann removed the type/backward-compatibility Something will be/is intentionally broken label Nov 8, 2018
@sebastianbergmann sebastianbergmann removed this from the PHPUnit 8.0 milestone Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants