Fix throwing Prophet error #1959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sebastianbergmann sorry to bother, but could you take a look at this PR? Its is fairly simple, and merging it will help me a lot in my projects :) |
sebastianbergmann
added a commit
that referenced
this pull request
Dec 10, 2015
|
Closed via 1f44c09 |
|
Thank you. Bug is still in 5.0 though https://github.com/sebastianbergmann/phpunit/blob/5.0/src/Framework/TestCase.php#L1009 |
|
PHPUnit 5.0 is no longer supported. |
|
Oh. Thank you for your help. |
|
@sebastianbergmann I think would make sense to merge this into the 4.8 as well. Right now using the prophecy integration and shouldBeCalled() is broken due to this. |
|
@ddelbondio A pull request for PHPUnit 4.8 would be appreciated. |
This was referenced Mar 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple fix allows to throw Prophet predictions exceptions.
Btw, very similar error is in current dev version https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestCase.php#L1002