Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insulated tests with phpdbg #1956

Merged
merged 1 commit into from Nov 17, 2015
Merged

Fix insulated tests with phpdbg #1956

merged 1 commit into from Nov 17, 2015

Conversation

nicolas-grekas
Copy link
Contributor

Fixes #1955

@GrahamCampbell
Copy link
Contributor

Nice fix. 👍

@sebastianbergmann
Copy link
Owner

Thanks. I do think, though, that this should go into the Runtime class. Or?

@nicolas-grekas
Copy link
Contributor Author

It could but it's not trivial: -d options needs to be before the eval-stdin.php on the command line, which means that simple concatenation doesn't work...

@sebastianbergmann
Copy link
Owner

Okay. Sounds like one more reason to work on #1342 then.

@bwoebi
Copy link
Contributor

bwoebi commented Nov 13, 2016

This, … well https://bugs.php.net/73484

This doesn't fix the bug, it just ends up not running the tests at all due to the use of php://input instead of php://stdin.

@sebastianbergmann
Copy link
Owner

Pull requests welcome! :-)

Truth be told, neither process isolation nor PHPDBG compatibility are high priority topics for me.

bwoebi added a commit to bwoebi/phpunit that referenced this pull request Nov 13, 2016
@bwoebi
Copy link
Contributor

bwoebi commented Nov 13, 2016

Yeah, see #2356 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants