From 091216b26833b5f002b8ff145f6dbe21b4e155af Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andreas=20M=C3=B6ller?= <am@localheinz.com>
Date: Sun, 5 May 2019 17:33:32 +0200
Subject: [PATCH] Fix: Allow using duration as value for order-by option via
 CLI

---
 src/TextUI/Command.php      | 7 ++++++-
 tests/end-to-end/help.phpt  | 2 +-
 tests/end-to-end/help2.phpt | 2 +-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/TextUI/Command.php b/src/TextUI/Command.php
index 9b66bc19272..9cc9a480e32 100644
--- a/src/TextUI/Command.php
+++ b/src/TextUI/Command.php
@@ -1158,7 +1158,7 @@ protected function showHelp(): void
   --printer <printer>         TestListener implementation to use
 
   --resolve-dependencies      Resolve dependencies between tests
-  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends
+  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends|duration
   --random-order-seed=<N>     Use a specific random seed <N> for random order
   --cache-result              Write run result to cache to enable ordering tests defects-first
 
@@ -1366,6 +1366,11 @@ private function handleOrderByOption(string $value): void
 
                     break;
 
+                case 'duration':
+                    $this->arguments['executionOrder'] = TestSuiteSorter::ORDER_DURATION;
+
+                    break;
+
                 default:
                     $this->exitWithErrorMessage("unrecognized --order-by option: $order");
             }
diff --git a/tests/end-to-end/help.phpt b/tests/end-to-end/help.phpt
index fb069f0e4d2..89220edf0e5 100644
--- a/tests/end-to-end/help.phpt
+++ b/tests/end-to-end/help.phpt
@@ -88,7 +88,7 @@ Test Execution Options:
   --printer <printer>         TestListener implementation to use
 
   --resolve-dependencies      Resolve dependencies between tests
-  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends
+  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends|duration
   --random-order-seed=<N>     Use a specific random seed <N> for random order
   --cache-result              Write run result to cache to enable ordering tests defects-first
 
diff --git a/tests/end-to-end/help2.phpt b/tests/end-to-end/help2.phpt
index b0c6ecb9e2f..bb6c002fa7c 100644
--- a/tests/end-to-end/help2.phpt
+++ b/tests/end-to-end/help2.phpt
@@ -89,7 +89,7 @@ Test Execution Options:
   --printer <printer>         TestListener implementation to use
 
   --resolve-dependencies      Resolve dependencies between tests
-  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends
+  --order-by=<order>          Run tests in order: default|reverse|random|defects|depends|duration
   --random-order-seed=<N>     Use a specific random seed <N> for random order
   --cache-result              Write run result to cache to enable ordering tests defects-first