Closed
Description
Hi, I tried the exact same build with php-file-iterator 1.4.3:
https://travis-ci.org/pug-php/pug-symfony/jobs/307889898
Execute all tests.
And with 1.4.4:
https://travis-ci.org/pug-php/pug-symfony/jobs/307872780
Output No tests executed!
Something with the new exclude system seems too restrictive.
Activity
Use phpunit/php-file-iterator 1.4.3 until bug fixed
sebastianbergmann commentedon Nov 27, 2017
Thank you for your report.
Please provide a minimal, self-contained, reproducing test case that shows the problem you are reporting.
Without such a minimal, self-contained, reproducing test case I will not be able to investigate this issue.
kylekatarnls commentedon Nov 27, 2017
But I don't know the root cause, I use PHPUnit as only one dependency in my project and find the breaking change on php-file-iterator by testing all sub-dependencies that changed meanwhile.
But the diff between 1.4.3 and 1.4.4 is pretty short and I think we can find the problem in few steps.
First can you show me where you unit-test you methods, like the one introduced by 1.4.4:
isExcludeParentOrSame
?I likely go throught 1.4.3...1.4.4#diff-47ab8ba983ef6248158109e94fb90f7bR114 by some wrong enabling of excludeAll and so all file that previously was taken are now ignored.
sebastianbergmann commentedon Nov 27, 2017
The fix for #30 was reverted in 730b01b and version 1.4.5 has been tagged.
kylekatarnls commentedon Nov 27, 2017
Thanks for the revert, I will try help you to reproduce.