Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change header without creating new diff builder #110

Open
furai opened this issue Jan 19, 2023 · 1 comment
Open

Ability to change header without creating new diff builder #110

furai opened this issue Jan 19, 2023 · 1 comment

Comments

@furai
Copy link

furai commented Jan 19, 2023

Hey,

It would be great to have an ability to change header on the go.

My usecase is that I'm looping through posts in database and after doing some changes to them I'm doing a string diff on that using StrictUnifiedDiffOutputBuilder and then I'm concatenating it into single report file. I've ended up creating new instance of builder each loop just to change the header. Would be nice to have some interface allowing me to change the header for already created diff builder.

Unless I've missed something....

Cheers,
Furai

@SpacePossum
Copy link
Contributor

Hi and thanks for your suggestion!

I think your use-case might be so rare that it might not be enough to change the interface of the builders for it.
The solution you found sounds good to me, although agreed that it might feels a bit much to recreate the builder each iteration, than again it is not very complex of big class/object so....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants