Don't clobber a previously set level filter #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bit of a race with the `log` API for initializing because it covers two atomic values. It's possible to observe a logger and attempt to use it before the max level is set. This change doesn't really make that race any racier than it was already, it just prevents the surprising behaviour of clobbering a previously set max level filter even if the logger itself isn't set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116
There's a bit of a race with the
logAPI for initializing because it covers two atomic values. It's possible to observe a logger and attempt to use it before the max level is set. This change doesn't really make that race any racier than it was already, it just prevents the surprising behaviour of clobbering a previously set max level filter even if the logger itself isn't set.