Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make search.checker reports false positiv 'img_src URL is invalid' #3311

Open
return42 opened this issue Mar 9, 2024 · 0 comments · May be fixed by #3312
Open

make search.checker reports false positiv 'img_src URL is invalid' #3311

return42 opened this issue Mar 9, 2024 · 0 comments · May be fixed by #3312
Assignees
@dalf
Labels
bug Something isn't working search.checker

Comments

@return42
Copy link
Member

return42 commented Mar 9, 2024 •
edited

Here is the output when I run the checker from my private IP: https://gist.github.com/return42/a4538daa4c8676d32edb2b7a5282e51a

Most of the img_src URL is invalid errors seem to me to be false negatives / I was able to load the images in all my samples / even with a simple curl:

curl 'https://www.artic.edu/iiif/2//f8fd76e9-c396-5678-36ed-6a348c904d27/full/843,/0/default.jpg' > test.jpg

Here is an excerpt from the report linked above / all images can be loaded:

Engine artic                         Error
    found languages: en eo fr
    simple         : img_src URL is invalid https://www.artic.edu/iiif/2//f8fd76e9-c396-5678-36ed-6a348c904d27/full/843,/0/default.jpg (query='life' lang='all' pageno=1 safesearch=0 time_range=None)
    simple         : img_src URL is invalid https://www.artic.edu/iiif/2//a38e2828-ec6f-ece1-a30f-70243449197b/full/843,/0/default.jpg (query='life' lang='all' pageno=1 safesearch=0 time_range=None)
    simple         : img_src URL is invalid https://www.artic.edu/iiif/2//4a04138f-43d8-cd9f-5ac4-478cd8828210/full/843,/0/default.jpg (query='life' lang='all' pageno=1 safesearch=0 time_range=None)
    simple         : img_src URL is invalid https://www.artic.edu/iiif/2//6f513908-03cc-b974-633b-adfce56b7936/full/843,/0/default.jpg (query='life' lang='all' pageno=1 safesearch=0 time_range=None)
    simple         : img_src URL is invalid https://www.artic.edu/iiif/2//d9bde524-38b2-4262-3338-e4d06a50746d/full/843,/0/default.jpg (query='life' lang='all' pageno=1 safesearch=0 time_range=None)

Related:
@return42 return42 added the bug Something isn't working label Mar 9, 2024
@return42 return42 mentioned this issue Mar 9, 2024
Open
@dalf dalf linked a pull request Mar 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dalf dalf

Labels
bug Something isn't working search.checker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checker: change image check dalf/searxng
2 participants
@return42 @dalf