New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tokio-rustls to v0.23 #927
Conversation
This change bumps the tokio-rustls version to pick up the new version of rustls. This helps to avoid duplicate dependencies when using other libraries that depend on rustls.
@seanmonstar I fixed the server config builder to use the newer types. PTAL :) |
) | ||
.map_err(|()| TlsConfigError::RsaParseError)?; | ||
let mut rsa = rustls_pemfile::rsa_private_keys(&mut key_vec.as_slice()) | ||
.map_err(|_e| TlsConfigError::RsaParseError)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These errors could be handled as TlsConfigError::Io
now, but I didn't want to change the public API more than needed.
This reverts commit e0cc66c.
e0cc66c removed what seemed like a bad semicolon (because nightly tests failed, iirc). I've reverted that change and confirmed tests pass locally. nightly tests might fail again, though 🤷 |
OK, the beta build fails with
Pretty sure this is broken on master, though. Removing this semicolon causes the stable build to hang. |
Yup, found the hang, fixed in master and merged in here so we can go green and merge. |
This change bumps the tokio-rustls version to pick up the new version of
rustls.
This helps to avoid duplicate dependencies when using other libraries
that depend on rustls.