Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Warp have a plan that support tokio 0.3 and bytes 0.6? #750

Closed
songday opened this issue Nov 17, 2020 · 1 comment
Closed

Does Warp have a plan that support tokio 0.3 and bytes 0.6? #750

songday opened this issue Nov 17, 2020 · 1 comment
Labels
feature New feature or request

Comments

@songday
Copy link

songday commented Nov 17, 2020

Is your feature request related to a problem? Please describe.
bytes 0.6 has some breaking changes

Describe the solution you'd like
downgrade bytes to 0.5 and tokio to 0.2

Describe alternatives you've considered
not yet :(

Additional context
Currently, I upgraded tokio from 0.2 to 0.3, and it depends bytes 0.6, so I upgrade bytes to 0.6 as well
but found many imcompatible places, such as: Part.data(), returns bytes/buf/buf_impl/Buf which does not exist in bytes 0.6

@songday songday added the feature New feature or request label Nov 17, 2020
@jxs
Copy link
Collaborator

jxs commented Nov 17, 2020

Hi, yes see #725

@jxs jxs closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants