Add method to expose missing/invalid reject names #447
Conversation
johnchildren
force-pushed
the
reject-name-method
branch
2 times, most recently
from
3315d41
to
9d06cd2
Compare
src/reject.rs
Outdated
| @@ -506,6 +506,13 @@ pub struct MissingHeader { | |||
| name: &'static str, | |||
| } | |||
|
|
|||
| impl MissingHeader { | |||
| /// Retrieve the name of the header that was missing | |||
| pub fn name(self) -> &'static str { | |||
There was a problem hiding this comment.
I'd suggest this should just return &str, in case we ever needed to store a dynamic String in some cases.
There was a problem hiding this comment.
Thanks, I was a bit unsure about this lifetime, but I have changed it as suggested to live as long as the rejection itself (I think). Hope this works!
There was a problem hiding this comment.
Oh, I didn't notice that these methods take self by value instead of by reference (&self). That should be changed, otherwise you can't call these methods from a &MissingHeader etc.
With that change, you don't need to specify any specific lifetime. They'll just look like pub fn name(&self) -> &str {.
There was a problem hiding this comment.
Oh sorry again, I actually didn't know you could do that for some reason. Anyway have hopefully fixed it now and have squashed my commits.
Add a name method to `MissingHeader`, `InvalidHeader` and `MissingCookie` that allow access to their internal name field. This is useful when recovering from rejections and down-casting to return specific replies for cases where additional information should be sent to the client.
johnchildren
force-pushed
the
reject-name-method
branch
from
29c717a
to
e664ebd
Compare
Add a name method to
MissingHeader,InvalidHeaderandMissingCookiethat allow access to their internal name field. This isuseful when recovering from rejections and down-casting to return
specific replies for cases where additional information should be sent
to the client.
Resolves #440