New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket filter with tokio-tungstenite #430
Conversation
@AlexCovizzi snapview/tokio-tungstenite#64 (comment) has been published. (https://github.com/snapview/tokio-tungstenite/releases/tag/v0.10.0 and crates) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi! and thanks! 🍰
can you run cargo fmt on the repo so that it passes the style check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! 👍 only Sean's approval is left
Sorry, I've been sick this week. @jxs if it looks good to you, you can merge any internal changes ;) I'd just want to discuss API changes. |
thanks Sean! hope you are feeling better now 😌 |
I tried to add support for
tokio-tungstenite
in the websocket filter. The only difference in the internal api is thatWebSocket::from_raw_websocket
now returns a Future.The main problem right now is that the
tokio-tungstenite
dependency is from the github repository because the version on crates.io uses futures v1.Edit: Reference #366