Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket filter with tokio-tungstenite #430

Merged
merged 9 commits into from Feb 6, 2020

Conversation

AlexCovizzi
Copy link
Contributor

@AlexCovizzi AlexCovizzi commented Jan 30, 2020

I tried to add support for tokio-tungstenite in the websocket filter. The only difference in the internal api is that WebSocket::from_raw_websocket now returns a Future.

The main problem right now is that the tokio-tungstenite dependency is from the github repository because the version on crates.io uses futures v1.

Edit: Reference #366

@kellytk
Copy link
Contributor

kellytk commented Jan 31, 2020

Copy link
Collaborator

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi! and thanks! 🍰
can you run cargo fmt on the repo so that it passes the style check?

src/filters/ws.rs Outdated Show resolved Hide resolved
src/filters/ws.rs Outdated Show resolved Hide resolved
src/filters/ws.rs Outdated Show resolved Hide resolved
src/filters/ws.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍 only Sean's approval is left

@jxs jxs requested a review from seanmonstar January 31, 2020 20:03
@seanmonstar
Copy link
Owner

Sorry, I've been sick this week.

@jxs if it looks good to you, you can merge any internal changes ;) I'd just want to discuss API changes.

@jxs
Copy link
Collaborator

jxs commented Feb 6, 2020

thanks Sean! hope you are feeling better now 😌

@jxs jxs merged commit 9dacd7d into seanmonstar:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants