Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update websocket filter to use tokio-tungstenite #366

Closed
jxs opened this issue Jan 8, 2020 · 3 comments
Closed

update websocket filter to use tokio-tungstenite #366

jxs opened this issue Jan 8, 2020 · 3 comments
Labels
feature New feature or request

Comments

@jxs
Copy link
Collaborator

jxs commented Jan 8, 2020

now that tokio-tungstenite has been updated to std::futures we could update the websockets filter to use it instead, should we wait for it to be published though?
@jxs jxs mentioned this issue Jan 8, 2020
Merged
@seanmonstar
Copy link
Owner

I can't remember why I removed the support before... What do we gain by adding it back? Less code to maintain?

@jxs
Copy link
Collaborator Author

jxs commented Jan 8, 2020

yeah, also less unsafe in the codebase since their implementation no longer has unsafe, and tls support for websockets afaik

@seanmonstar seanmonstar added the feature New feature or request label Jan 24, 2020
@AlexCovizzi AlexCovizzi mentioned this issue Jan 30, 2020
Merged
@jxs
Copy link
Collaborator Author

jxs commented Jul 7, 2020

fixed with #430

@jxs jxs closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @jxs