Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warp fails to compile without the websocket feature #352

Closed
SSheldon opened this issue Dec 28, 2019 · 0 comments
Closed

warp fails to compile without the websocket feature #352

SSheldon opened this issue Dec 28, 2019 · 0 comments

Comments

@SSheldon
Copy link
Contributor

The websocket functionality is behind a default feature so that it can be disabled. However, disabling the feature results in the crate failing to compile with the following error:

failed to resolve: maybe a missing crate `ws`?
   --> src/reject.rs:253:37
    |
253 |     MissingConnectionUpgrade(crate::ws::MissingConnectionUpgrade),
    |                                     ^^ maybe a missing crate `ws`?

error: aborting due to previous error

The problematic code is behind a macro, so I don't immediately see a way to fix it. The macro was introduced in #311, but the issue appeared to still exist in the commit beforehand, albeit erroring on a different line:

error[E0433]: failed to resolve: maybe a missing crate `ws`?
   --> src/reject.rs:400:35
    |
400 |                     e.is::<crate::ws::MissingConnectionUpgrade> () {
    |                                   ^^ maybe a missing crate `ws`?

error: aborting due to previous error
jxs added a commit to jxs/warp that referenced this issue Dec 28, 2019
…anmonstar#352

- add step test for --no-default-features
- remove no longer used travis badge
jxs added a commit to jxs/warp that referenced this issue Dec 28, 2019
…anmonstar#352

- add step test for --no-default-features
- remove no longer used travis badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant