Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Server::tls(path, path) to return a builder instead #340

Merged
merged 1 commit into from Dec 18, 2019
Merged

Change Server::tls(path, path) to return a builder instead #340

merged 1 commit into from Dec 18, 2019

Conversation

seanmonstar
Copy link
Owner

closes #223

@jxs I had some design changes to propose for #317, and figured I'd just put them into a commit.

@seanmonstar seanmonstar requested a review from jxs December 17, 2019 20:24
jxs
jxs approved these changes Dec 18, 2019
View reviewed changes
Copy link
Collaborator

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah the way you improved the set methods with with_tls maintains the same ergonomics, thanks!
only minor nit, should the Error updates be made on a separate commit and addressed here on the PR?

@seanmonstar seanmonstar merged commit 3a16d83 into master Dec 18, 2019
@seanmonstar seanmonstar deleted the pr/317 branch December 18, 2019 23:58
masonforest pushed a commit to masonforest/warp that referenced this pull request Dec 20, 2019
@seanmonstar @masonforest
Change Server::tls(path, path) to return a builder instead (seanmonst…
732cf4a 
…ar#340)

closes seanmonstar#223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Server::tls(path, path) to return a builder instead
2 participants
@seanmonstar @jxs