Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket permessage-deflate extension support #770

Open
novacrazy opened this issue Dec 31, 2020 · 2 comments · May be fixed by #1016
Open

WebSocket permessage-deflate extension support #770

novacrazy opened this issue Dec 31, 2020 · 2 comments · May be fixed by #1016
Labels
feature New feature or request

Comments

@novacrazy
Copy link

Sec-WebSocket-Extensions: permessage-deflate and such is available in Firefox and Chrome, and utilizing it natively would eliminate the need to load large JavaScript decompression libraries on the client-side. (Large as in about 28KB min-gzipped)
The native implementation in-browser is probably faster than Javascript codecs as well.

Ideally, this could be automatic, as the compression is transparent. However, it should also be able to signal to the user code that compression extensions are unavailable, so it could fallback and signal to load those aforementioned libraries.

The alternative would be to just continue doing it manually. I'm simply using flate2 and sending/receiving binary messages.

Perhaps this is more an issue for tokio-tungstenite?

@novacrazy novacrazy added the feature New feature or request label Dec 31, 2020
@jxs
Copy link
Collaborator

jxs commented Jan 12, 2021

Hi! yeah, see snapview/tungstenite-rs#144

@kazk
Copy link

kazk commented Sep 13, 2021

See snapview/tungstenite-rs#235. To support warp, something like master...kazk:permessage-deflate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants