feat: enable client to be a service without ownership #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoeinstein
force-pushed
the
client-without-ownershio
branch
from
70dcb7d
to
a25d5df
Compare
seanmonstar
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current impl on
Client, using a client as a service requires ownership. This can be done relatively cheaply by cloning, but is a bit of a UX sore. We can improve this by adding an impl on the shared reference. This will enable usage of a client as a service in a way that doesn't require explicit cloning for repeated use where not required. This is analogous to the impls on thehyper::Client.