[rustls] identity: handle elliptic curve private keys #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'm generally pro on this addition. I'm starting to worry about a bunch of this TLS code that doesn't really have tests, but that's not the fault of this PR. More just me worrying... Anyways, I think this just needs a rebase, since I already merged a different PR that updated the dependency version. |
This commit improves the user experience of the users leveraging rustls. When building the identity to use for requests, it's now possible to use also private keys using Elliptic Curve that are encoded with SEC1 standard. This is the default encoding used by openssl when EC keys are created. Prior to this commit users had to convert those keys from the SEC1 encoding to the PKCS 8 one, which is something not trivial. This feature has been recently added to rustls-pemfile crate. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
flavio
force-pushed
the
rustls-identity-handle-elliptic-curve-private-keys
branch
from
96704eb
to
1fac3cd
Compare
I get it... thanks for being positive about this PR
Done |
seanmonstar
approved these changes
Apr 15, 2022
flavio
added a commit
to flavio/krew-wasm
that referenced
this pull request
Apr 20, 2022
This is required to include the fix merged upstream inside of seanmonstar/reqwest#1526 Thanks to this fix, krew-wasm can cannot to kubernetes clients that are using elliptic curve keys to authenticate users (such as k3s and k3d). Signed-off-by: Flavio Castelli <fcastelli@suse.com>
flavio
added a commit
to flavio/krew-wasm
that referenced
this pull request
Apr 20, 2022
This is required to include the fix merged upstream inside of seanmonstar/reqwest#1526 Thanks to this fix, krew-wasm can cannot to kubernetes clients that are using elliptic curve keys to authenticate users (such as k3s and k3d). Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the user experience of the users leveraging rustls.
When building the identity to use for requests, it's now possible to use also private keys using Elliptic Curve that are encoded with SEC1 standard.
This is the default encoding used by openssl when EC keys are created. Prior to this commit users had to convert those keys from the SEC1 encoding to the PKCS 8 one, which is something not trivial.
This feature has been recently added to rustls-pemfile crate. This commit update the
rustls-pemfilecrate to its latest stable release.I also had to change a little the code used to extract the private keys from the PEM file. That's because
rustls-pemfiledoens't provide a high level API that extracts Elliptic Curve keys.