Fix redirect limited(0) should not follow redirects #1645
Merged
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phankydn
changed the title
seanmonstar
reviewed
Oct 7, 2022
| @@ -128,7 +128,7 @@ impl Policy { | |||
| match self.inner { | |||
| PolicyKind::Custom(ref custom) => custom(attempt), | |||
| PolicyKind::Limit(max) => { | |||
| if attempt.previous.len() == max { | |||
| if attempt.previous.len() >= max { | |||
There was a problem hiding this comment.
Wouldn't this still be without the change? The previous length should be 0, and max is 0... Is there a time that isn't true?
There was a problem hiding this comment.
reqwest/src/async_impl/client.rs
Line 1975 in a0a7db0
Yes, it isn't true because the url is pushed to the
previousbefore calling check, so the length always has at least 1 item.
There was a problem hiding this comment.
Oh, of course! Want to readd the test but with a URL in the previous Vec as well, so we catch this if it ever changes?
seanmonstar
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1639