Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiline header in response #1521

Closed
eyalsatori opened this issue Apr 10, 2022 · 2 comments
Closed

Add support for multiline header in response #1521

eyalsatori opened this issue Apr 10, 2022 · 2 comments

Comments

@eyalsatori
Copy link
Contributor

eyalsatori commented Apr 10, 2022

Following this discussion - I saw that the server send me a set-cookie header with multiline value (CLRF in the middle of the cookie).

this is print from curl output:

Set-Cookie: ___utmvbBNuXKscZ=DZc
XfeOcall: LtO; path=/; Max-Age=900; Secure; SameSite=None

I saw that hyper support multiline header by configuration , and I thought maybe it's can be added also as ClientBuilder flag .

If you ok with this attitude , I will start to working on PR .. (I think it's should be pretty convenient - I will follow the path of http1_title_case_headers )

@alexsatori
Copy link

Such "malformed" cookies are generated by a WAF for detection purposes. So there is a good reason to support it in the library.

https://stackoverflow.com/questions/62170999/weird-malformed-cookies-returned-from-rest-api-sometimes

eyalsatori added a commit to eyalsatori/reqwest that referenced this issue Apr 12, 2022
eyalsatori added a commit to eyalsatori/reqwest that referenced this issue Apr 19, 2022
eyalsatori added a commit to eyalsatori/reqwest that referenced this issue Apr 19, 2022
seanmonstar pushed a commit that referenced this issue Apr 19, 2022
@eyalsatori
Copy link
Contributor Author

Added in #1523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants