Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async (hyper 0.11) #149

Closed
theduke opened this issue Jun 13, 2017 · 3 comments
Closed

Async (hyper 0.11) #149

theduke opened this issue Jun 13, 2017 · 3 comments

Comments

@theduke
Copy link
Contributor

theduke commented Jun 13, 2017

Since hyper 0.11 has been released,
can a switch to 0.11 go ahead already?

Like mentioned elsewhere, a SyncClient plus an AsyncClient would be neat.

If can lend a hand.

@seanmonstar
Copy link
Owner

Yes, work can start. Since an async client necessitates use of the Future trait, and that won't stabilize before reqwest 1.0, an exposed async Client would need to be in a separate crate.

However, there is benefit in using this async crate inside the sync one, as it does a better job of detecting dead sockets and allowing connect/dns timeouts, and make use of the new headers and mime updates.

@seanmonstar
Copy link
Owner

Ah, this was done in #151.

@theduke
Copy link
Contributor Author

theduke commented Jun 22, 2017

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants