Add HTTP Upgrade support to Response. #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Nov 30, 2021
luqmana
force-pushed
the
http-upgrade
branch
from
05202a2
to
f6d6e3d
Compare
seanmonstar
reviewed
Mar 14, 2022
luqmana
force-pushed
the
http-upgrade
branch
2 times, most recently
from
3f511ca
to
56dc927
Compare
seanmonstar
approved these changes
Jul 28, 2022
Closed
|
No problem! Is a release scheduled any time soon so we can get a version with this on crates.io? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method,
Response::upgrade, which consumes the given Response and returns a future for a possible HTTP upgrade. On success the future will yield a new type,Upgraded(a thin wrapper around hyper'sUpgradedtype), which implementsAsyncRead/AsyncWriteover the underlying connection.As part of this, reqwest's
Responsetype now no longer takes apart the originalhyper::Responsebut rather stores it and maps the Body type toDecoder. This along with hyperium/hyper#2680 makes the new upgrade method just a thin wrapper around hyper's.