Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update async body doc #1357

Merged
merged 1 commit into from Oct 18, 2021
Merged

Update async body doc #1357

merged 1 commit into from Oct 18, 2021

Conversation

fredr
Copy link
Contributor

@fredr fredr commented Oct 16, 2021

Remove File from examples of what .body() accept, as far as I can tell File is only available in blocking and not in async

@fredr
Update async body doc
c6c0367 
Remove File from examples of what .body() accept
seanmonstar
seanmonstar approved these changes Oct 18, 2021
View reviewed changes
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

(It does make me wonder, maybe we could provide a correct conversion to a tokio::fs::File wrapped in an tokio_util::io::ReaderStream to make it more convenient for people?)

@seanmonstar seanmonstar enabled auto-merge (squash) October 18, 2021 16:51
@seanmonstar seanmonstar merged commit d35c311 into seanmonstar:master Oct 18, 2021
@fredr fredr deleted the patch-1 branch October 18, 2021 18:29
@fredr fredr mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredr @seanmonstar