Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wasm client: pass response header to builder by reference #1350

Merged
merged 1 commit into from Oct 13, 2021
Merged

fix: wasm client: pass response header to builder by reference #1350

merged 1 commit into from Oct 13, 2021

Conversation

6543
Copy link
Contributor

@6543 6543 commented Oct 10, 2021

this addition fix wasm build at Calciumdibromid/CaBr2#861

@6543
Copy link
Contributor Author

6543 commented Oct 10, 2021

I wonder why this is not covered by the ci ...

If you have more questions or I should alter some things please tell me :)

@6543 6543 mentioned this pull request Oct 10, 2021
Merged
@6543
Copy link
Contributor Author

6543 commented Oct 11, 2021

@seanmonstar hi would be nice if you could have a look at this ...

@seanmonstar
Copy link
Owner

Is this to fix #1349?

@6543
Copy link
Contributor Author

6543 commented Oct 12, 2021

@seanmonstar sadly: no ... it's another bug you could find the log here: https://github.com/Calciumdibromid/CaBr2/pull/861/checks?check_run_id=3853271693

what's sad is, that i could not trigger it on this repo, i do need our project to do so ...

@6543
Copy link
Contributor Author

6543 commented Oct 12, 2021

cc @crapStone if you have an idear how to write a test for it

@6543 6543 changed the title fix: async fn fetch fix: async fn fetch: set response header dont support &str directly Oct 12, 2021
crapStone
crapStone reviewed Oct 12, 2021
View reviewed changes
src/wasm/client.rs Outdated Show resolved Hide resolved
@crapStone
Copy link
Contributor

@seanmonstar our build fails because of the following error:
image

The header function of the response-builder only works with &str and not with owned Strings.

@6543
Copy link
Contributor Author

6543 commented Oct 12, 2021

thanks will test & ajust

@6543 6543 changed the title fix: async fn fetch: set response header dont support &str directly fix: wasm client: pass response header to builder by reference Oct 12, 2021
@6543 @crapStone
fix: wasm client: pass response header to builder by reference
0a4b123 
Co-authored-by: crapStone <crapstone01@gmail.com>
@6543
Copy link
Contributor Author

6543 commented Oct 12, 2021

@seanmonstar updated ;) ... i just had to borrow it :D

@6543
Copy link
Contributor Author

6543 commented Oct 13, 2021

@seanmonstar frendly ping ;)

@seanmonstar seanmonstar merged commit c9217d8 into seanmonstar:master Oct 13, 2021
@6543 6543 deleted the fix-wasm-client branch October 14, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crapStone crapStone crapStone left review comments

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@6543 @seanmonstar @crapStone