Allow overriding of DNS resolution to specified IP addresses(#561) #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
requested changes
Jun 2, 2021
|
New version with the requested changes. I'm afraid I'm not great with the Github PR process so I did a force push and this may have made inter-version comparison more difficult. The only changes are:
|
campbellC
added a commit
to campbellC/third-wheel
that referenced
this pull request
Jun 3, 2021
seanmonstar
reviewed
Jun 4, 2021
|
Are there any more changes requested for this patch? Cheers. |
seanmonstar
approved these changes
Jun 15, 2021
|
Ah, to make the older Rust version work, you could use |
|
I have switched to futures_util and tested locally that it builds on 1.46. No other changes made so I expect workflows will work now. Thanks! |
…tar#561) This change allows users to bypass the selected DNS resolver for specific domains. The allows, for example, to make calls to a local TLS server by rerouting a given domain to 127.0.0.1. The approach I've taken for the design is to wrap the resolver in an outer service. This leads to a fair amount of boilerplate code mainly to be able to explain the typing to the compiler. The actual business logic is very simple for the number of lines involved. Closes seanmonstar#561
|
I rebased onto the new changes and no conflicts there either so merge should be simple. |
pfernie
added a commit
to pfernie/reqwest
that referenced
this pull request
Jun 25, 2021
* master: add option to disable http2 upgrade (seanmonstar#1292) Fix documentation of http1_title_case_headers() (seanmonstar#1294) CI: make a single final job that depends on all others (seanmonstar#1291) Fix bare url warnings in `multipart` docs (seanmonstar#1289) v0.11.4 Allow overriding of DNS resolution to specified IP addresses(seanmonstar#561) (seanmonstar#1277) WASM: Add `try_clone` implementations to `Request` and `RequestBuilder` (seanmonstar#1286) Add native-tls-alpn feature (seanmonstar#1283)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to bypass the selected DNS resolver for
specific domains. The allows, for example, to make calls to a local TLS
server by rerouting a given domain to 127.0.0.1.
The approach I've taken for the design is to wrap the resolver in an
outer service. This leads to a fair amount of boilerplate code mainly to
be able to explain the typing to the compiler. The actual business logic
is very simple for the number of lines involved.
One alternative option I considered was using an inline
tower_serviceinstead of a struct. This is possible at the cost of making reqwest's HttpConnector generic, because I could not find a way to state the type of this inlined struct. This was a bigger change than I wanted to make but happy to reconsider, it would reduce the boilerplate for sure.NB: this change adds a new dependency (itertools). This is simply to use one struct (itertools::Either) which would be simple to implement directly. If keeping the dependency tree short is needed this is a small change I believe.
Closes #561