Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporated range operator and collapsible_match #1214

Merged
merged 2 commits into from Mar 17, 2021
Merged

Incorporated range operator and collapsible_match #1214

merged 2 commits into from Mar 17, 2021

Conversation

bishtpawan
Copy link
Contributor

@bishtpawan bishtpawan commented Mar 10, 2021 •
edited

Improved code readability and quality by using:

  1. Range operator for comparison
  2. Collapsible_match

@bishtpawan
Improve code readability and quality by:
ef89151 
1. Use of range operator for comparison
2. Use of collapsible_match
@bishtpawan
Copy link
Contributor Author

@seanmonstar can you please have a look at it? Thanks

seanmonstar
seanmonstar requested changes Mar 15, 2021
View reviewed changes
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

A couple of the changes are less clear to me, but I'm happy to merge condensing of one of the match blocks.

src/connect.rs Outdated Show resolved Hide resolved
src/proxy.rs Outdated Show resolved Hide resolved
@seanmonstar
Copy link
Owner

Yes please, let's go ahead with the 2 changes I requested.

@bishtpawan
Copy link
Contributor Author

@seanmonstar, I've made the changes.
Thanks

@seanmonstar seanmonstar merged commit 544282a into seanmonstar:master Mar 17, 2021
@seanmonstar
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bishtpawan @seanmonstar