Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: cgroupv2 support #130

Open
PureWhiteWu opened this issue Feb 21, 2023 · 3 comments
Open

Feature Request: cgroupv2 support #130

PureWhiteWu opened this issue Feb 21, 2023 · 3 comments

Comments

@PureWhiteWu
Copy link
Sponsor Contributor

PureWhiteWu commented Feb 21, 2023

Currently num_cpus doesn't support cgroupv2, maybe we should support it?
Spec: https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.html
K8s ref: https://kubernetes.io/docs/concepts/architecture/cgroups/

@PureWhiteWu PureWhiteWu changed the title Proposal: cgroupv2 support Feature Request: cgroupv2 support Feb 21, 2023
@PureWhiteWu
Copy link
Sponsor Contributor Author

We can refer to uber-go/automaxprocs@ad6f05b and uber-go/automaxprocs@721b013 .

I will take a look at this when I have time.

@asfaltboy
Copy link

According to this PR, cgroups v2 support was added.

@PureWhiteWu can you give an example of the issue?

For context, I'm debugging some odd behaviour with bad logical CPUs detection under Kubernetes, and I'm interested to see if there's still a bug in some case (when memory limit isn't specified in the pod.spec.container.resources.limits field).

@PureWhiteWu
Copy link
Sponsor Contributor Author

@asfaltboy Yes, the cgroups v2 seems not working correctly on our kubernetes environment.
I'll find an example next week when I'm at work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants