New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cgroup): fix parse zero or multi optional fields in mountinfo #113
fix(cgroup): fix parse zero or multi optional fields in mountinfo #113
Conversation
In addition, I think this is a critical bug, which may cause performance greatly affected in containers(in fact, we are encountering this bug in our production environment). |
Thanks for the PR! A problem we currently have is that the CI is no longer active on new PRs. We need to move off Travis-CI, and probably onto Github Actions. |
Okay, I've already sent another PR #114 to set up github actions. |
Ok, so I think if you rebase this branch off master, we'll get the proper CI going... |
89fff6a
to
c3e0146
Compare
Seems that Rust 1.13 is too old, can we update it to a newer version? |
I've tested and found that this requires a minimal version of 1.22, so I changed to version in ci to 1.22. |
In general, I've taken a conservative approach to MSRV upgrades, and only done so when a new thing in Rust was needed to provide essential functionality. What is needed here that's new? Is it just |
I've fixed that on 1.13 and it should be fine now.
After this is merged, could you please release a new version? |
And release as v1.13.1. Thanks for the work! |
There could be zero or more optional fields in mountinfo according to https://man7.org/linux/man-pages/man5/proc.5.html
And also there's some minor code cleanup.