New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cull unused libc dependency on windows #101

Merged

seanmonstar merged 1 commit into seanmonstar:master from MaulingMonkey:pr-cull-libc

Sep 8, 2020

Contributor

MaulingMonkey commented Sep 8, 2020 •

edited

libc is already not used on windows, no need to download & compile it:

num_cpus/src/lib.rs

Lines 34 to 35 in 9b146fa

    
           #[cfg(not(windows))] 
        
           extern crate libc;

(EDIT: looks like this shaves a good 15 seconds off each appveyor build? 182 vs 185)


          Cull unused libc dependency on windows

174edf4

seanmonstar approved these changes

View reviewed changes

seanmonstar merged commit b423db0 into seanmonstar:master

Owner

seanmonstar commented Sep 8, 2020

Nice catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment