Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sensors in the List Devices component #614

Open
justsayknarf opened this issue Mar 25, 2024 · 3 comments
Open

Support sensors in the List Devices component #614

justsayknarf opened this issue Mar 25, 2024 · 3 comments
Assignees
Labels
component Component development DeviceDetails Affects the DeviceDetails component. DeviceTable Affects the DeviceTable component.

Comments

@justsayknarf
Copy link

Sensors should be returned and displayed properly in the List Devices Seam Component.

If the Seam Component is being used to display all devices being managed, sensors should be displayed alongside locks as expected.

Context

https://hello-seam.slack.com/archives/C022B8LHHUJ/p1711053555581979

@mikewuu mikewuu self-assigned this Mar 26, 2024
@mikewuu
Copy link
Contributor

mikewuu commented Mar 26, 2024

@justsayknarf , @miken-seam , is there a design we can use for this, perhaps just to get it out the door initially?

@miken-seam
Copy link

miken-seam commented Mar 28, 2024

I did quite a bit of design in figma for noise sensors. The seam component design supports NoiseAware and Minut. They do thresholds differently but we have a single UI that supports both. I need to review the work and make sure the prototypes are intact.

See videos of the prototypes on Notion

Use the figma interactive prototype (Note: There are hints in the prototype's lower right corner telling you what to click on next.)



image

@razor-x
Copy link
Collaborator

razor-x commented Mar 28, 2024

Nice! @mikewuu The first PR can simply implement this card without the "Noise Thresholds" section. And show them in the DeviceList. Then the devices will at least appear in the list and on a card.

@razor-x razor-x added DeviceDetails Affects the DeviceDetails component. DeviceTable Affects the DeviceTable component. component Component development labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component Component development DeviceDetails Affects the DeviceDetails component. DeviceTable Affects the DeviceTable component.
Projects
None yet
Development

No branches or pull requests

4 participants