Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manufacturers array is case sensitive in <SupportedDevicesTable /> #538

Open
seveibar opened this issue Oct 25, 2023 · 2 comments
Open

manufacturers array is case sensitive in <SupportedDevicesTable /> #538

seveibar opened this issue Oct 25, 2023 · 2 comments
Labels
SupportedDevicesTable Affects the SupportedDevicesTable component.

Comments

@seveibar
Copy link
Contributor

seveibar commented Oct 25, 2023

should be case-insensitive, meaning ["2n"] should return the same result as ["2N"], might be an issue w/ devicedb, @codetheweb may be able to leave a quick comment to direct the implementor to the right repo

@seveibar seveibar changed the title manufacturers array is case sensitive manufacturers array is case sensitive in <SupportedDevicesTable /> Oct 25, 2023
@razor-x
Copy link
Collaborator

razor-x commented Oct 25, 2023

I actually tried to make it work with case insensitive, but I did not see a way with LQL. I tried to use regex like key:/foo/i instead of key:"foo" but was getting this error from the backend https://github.com/gajus/liqe/blob/efb877db58b8926c20b29ba8b30b075b25af0992/src/parse.ts#L59

I cannot use key:foo since the input may have spaces or other characters.

@razor-x razor-x added the SupportedDevicesTable Affects the SupportedDevicesTable component. label Oct 25, 2023
@codetheweb
Copy link
Contributor

It may be simplest to implement a custom query handler in the devicedb endpoint, see here for an example: https://contra.com/p/WobOBob7-building-advanced-sql-search-from-a-user-text-input

@mastafit mastafit assigned mastafit and unassigned mastafit Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SupportedDevicesTable Affects the SupportedDevicesTable component.
Projects
None yet
Development

No branches or pull requests

4 participants