Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo images look small in supported devices component #426

Open
miken-seam opened this issue Sep 2, 2023 · 3 comments
Open

Logo images look small in supported devices component #426

miken-seam opened this issue Sep 2, 2023 · 3 comments
Labels
bug Something isn't working component Component development design Design requirements SupportedDevicesTable Affects the SupportedDevicesTable component.

Comments

@miken-seam
Copy link

image

Issues:

  • Logos images look smaller than some of the device images
  • The device and logo images are the same dimensions, but some devices are cropped in a way that makes them seem smaller.
  • In general, the device images used are inconsistently sized.
  • In general, the device images are fairly low resolution 96x96

Solution:

  • Device image: Use a source of device images where the images have been cropped so they are all optically balanced.
  • Logos: Changing the design to use horizontal logos would help differentiate the logos from the devices. We have horizontal logos in dashboard, but not sure how many of those there are.

Modified header design:
I can do a modified header design using the horizontal logos that we used in the dashboard linked accounts page. https://dashboard.seam.co/linked-accounts

  • But we will need to be able to ensure that there is a complete set of logos in the set.

So I'll assign myself this to do the modified design, but @sybohy one of the issues is the inconsistency of the device images (which are only 96x96 in this case). How can we create and maintain a single set of device images that are balanced optically?

image

cc @sybohy

@razor-x razor-x changed the title [UI issue] Logo images look small in supported devices component SupportedDevicesTable - Logo images look small in supported devices component Sep 5, 2023
@razor-x razor-x added bug Something isn't working design Design requirements component Component development SupportedDevicesTable Affects the SupportedDevicesTable component. labels Sep 5, 2023
@razor-x razor-x changed the title SupportedDevicesTable - Logo images look small in supported devices component Logo images look small in supported devices component Sep 5, 2023
@razor-x razor-x assigned mikewuu and unassigned razor-x and miken-seam Sep 5, 2023
@mikewuu
Copy link
Contributor

mikewuu commented Oct 2, 2023

@miken-seam @razor-x is there an updated design for this?

@mikewuu mikewuu assigned miken-seam and unassigned mikewuu Oct 3, 2023
@razor-x
Copy link
Collaborator

razor-x commented Oct 3, 2023

@codetheweb Will the updates to the devicedb images solve this or help here?

@sybohy
Copy link

sybohy commented Oct 3, 2023

Will the updates to the devicedb images solve this or help here

Yes and no.

The yes-part: Right now people are grabbing manufacturer logo and device images in random places and putting them in their respective projects (components, console...etc). So we clearly have many sources of truth, which leads to these issues. In principle, device-db solves the problem by unifying on a single image for each device.

The no-part: EXCEPT device-db doesn't have a strong authority/guidance on how sizing/padding should be handled between all devices. All device images are squares. But some device images have padding. Others do not. This leads to inconsistency in our UI.

Below is a beautiful example of this visual inconsistency (which you can see live here. Notice how devices are all squares of equal sizes, but that the devices vary quite a bit. The device images are pulled from the new device-db.
image

Proposed Solution: I think @miken-seam needs to define guidelines on device image, logo images...etc with respect to padding, filtering...etc. Then we fix all images that get uploaded to device-db, and then devices should look much more uniform. Hope this makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component Component development design Design requirements SupportedDevicesTable Affects the SupportedDevicesTable component.
Projects
None yet
Development

No branches or pull requests

4 participants