Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SeamApiException to SeamHttpApiError #48

Closed
andrii-balitskyi opened this issue May 10, 2024 · 1 comment · Fixed by #58
Closed

Rename SeamApiException to SeamHttpApiError #48

andrii-balitskyi opened this issue May 10, 2024 · 1 comment · Fixed by #58

Comments

@andrii-balitskyi
Copy link
Collaborator

No description provided.

This was referenced May 10, 2024
Merged
Merged
@razor-x razor-x mentioned this issue May 17, 2024
Closed
@razor-x
Copy link
Contributor

razor-x commented May 17, 2024

I don't think the error message should contain this interpolated data, but I need to run a few local tests to see how to best display the error

f"SeamApiException: status={self.status_code}, request_id={self.request_id}, metadata={self.metadata}"

@razor-x razor-x mentioned this issue May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename SeamApiException to SeamHttpApiError seamapi/python-next
2 participants
@razor-x @andrii-balitskyi