Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containers vendor #2147

Open
2 tasks
kakaZhou719 opened this issue Mar 28, 2023 · 2 comments
Open
2 tasks

Update containers vendor #2147

kakaZhou719 opened this issue Mar 28, 2023 · 2 comments
Assignees
Labels
kind/feature Category issues or PRs related to feature request performance

Comments

@kakaZhou719
Copy link
Member

kakaZhou719 commented Mar 28, 2023

Issue Description

  • 1. support set load tmp dir for save and load, we could set tmp-dir flag to sysContext.BigFilesTemporaryDir.
  • 2. Waiting for a separate functions Or string flag from containers SDK, which will not guess what type of input tar file. this is more time-saving.

more to see : containers/common#1376

Type: feature request

Describe what feature you want

for 1 , we could use --tmp-dir flag to do it.
sealer load -i my.tar --tmp-dir /root/my-tmp
sealer save abc:v1 -o my.tar --tmp-dir /root/my-tmp

Additional context

Add any other context or screenshots about the feature request here.

@kakaZhou719 kakaZhou719 added the kind/feature Category issues or PRs related to feature request label Mar 28, 2023
@kakaZhou719 kakaZhou719 added this to the release-0.9.4 milestone Mar 28, 2023
@kakaZhou719
Copy link
Member Author

related go mod version

 github.com/containers/buildah v1.29.1
  github.com/containers/common v0.51.0
  github.com/containers/image/v5 v5.24.1
  github.com/containers/ocicrypt v1.1.7
  github.com/containers/storage v1.45.3

@cubxxw
Copy link
Collaborator

cubxxw commented Mar 31, 2023

  • add a flag

    	// TODO: Waiting for implementation, not yet supported
    	flags.StringVar(&loadOpts.TmpDir, "tmp-dir", "", "Set temporary directory when load image. if not set, use system temporary directory(`/var/tmp/`)")  
  • come true MultiImageArchive

    	// MultiImageArchive - if true, the container engine allows for storing
    	// archives (e.g., of the docker-archive transport) with multiple
    	// images.  By default, Podman creates single-image archives.
    	MultiImageArchive bool `toml:"multi_image_archive,omitempty"`
  • update pack

Do I need to update the following packages?

  • Temporary load directory primitives, garbage collection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or PRs related to feature request performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants