Replace deprecated method usage

[PikachuEXE]

URI.escape is obsoleted: ruby/ruby@238b979

[PikachuEXE]

Will be ready for review once #116 merged, since this is based on that PR
I want to rebase before marking this PR as ready anyway

[PikachuEXE]

Screw it, I rebased on master without changes in #116 :D

[PikachuEXE]

I am not sure if we should use URI::Parser#escape instead which is available in 1.9
https://ruby-doc.org/stdlib-1.9.1/libdoc/uri/rdoc/URI/Parser.html
Sinatra seems using it
sinatra/sinatra-contrib#127

Edit: A test case failed if we use URI::Parser#escape`

fastimage/test/test.rb

Lines 291 to 295 in 8386e11

	def test_should_handle_permanent_redirect_with_complex_relative_url
	register_redirect(TestUrl, "/pho to.gne?rb=1&short=Vv4Und")
	register_redirect("#{TestUrl}pho%20to.gne?rb=1&short=Vv4Und", "/" + GoodFixtures.keys.first)
	assert_equal GoodFixtures[GoodFixtures.keys.first][1], FastImage.size(TestUrl, :raise_on_failure=>true)
	end

[PikachuEXE]

Rebased on latest master and test passed

[sdsykes]

Thanks I'll look at this, and aim to make a release shortly.

[PikachuEXE]

Reminder to look at this PR~

[PikachuEXE]

On vacation?

[sdsykes]

For another week!

[PikachuEXE]

Have a good one!

[sdsykes]

These are not the same?

irb(main):003:0> ERB::Util.url_encode("/pho to.gne?rb=1&short=Vv4Und")
=> "%2Fpho%20to.gne%3Frb%3D1%26short%3DVv4Und"
irb(main):004:0> URI.escape("/pho to.gne?rb=1&short=Vv4Und")
=> "/pho%20to.gne?rb=1&short=Vv4Und"

[PikachuEXE]

Forgot to test with erb required
Anyway updated to use URI::DEFAULT_PARSER as there is already a patch for old rubies

[PikachuEXE]

Build passed

Any chance we can see the CI check status in future PR without manually checking it?

[PikachuEXE]

Hope to see a new release soon~

[PikachuEXE]

Will there be a new release this or next week?

[sdsykes]

I released it already....

[PikachuEXE]

Sorry
Forgot watch for new releases
And my gemfile is pointing to specific commit