Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with RuboCop 0.77.0 #107

Closed
tagliala opened this issue Nov 28, 2019 · 6 comments · Fixed by #109
Closed

Not compatible with RuboCop 0.77.0 #107

tagliala opened this issue Nov 28, 2019 · 6 comments · Fixed by #109

Comments

@tagliala
Copy link
Contributor

tagliala commented Nov 28, 2019

Problem:
Layout/TrailingBlankLines has been renamed to Layout/TrailingEmptyLines

@guillaumebriday
Copy link

Same issue I think, I have false positive with this cops since Rubocop 0.77.0.

@tagliala
Copy link
Contributor Author

I'm available to submit a new PR but I would also take care of other stuff.

I will have time during this weekend or later this evening

@jacobat
Copy link

jacobat commented Nov 29, 2019

#108

@tagliala
Copy link
Contributor Author

Ok, that would work and preserve backward compatibility. I was thinking about something more invasive 👀

tagliala added a commit to tagliala/slim-lint that referenced this issue Nov 30, 2019
A lot of cops have been renamed since 0.50.0, this commit fixes the
default configuration and sets the minimum RuboCop required version to
0.77.0

Fix: sds#107
tagliala added a commit to tagliala/slim-lint that referenced this issue Nov 30, 2019
A lot of cops have been renamed since 0.50.0, this commit fixes the
default configuration and sets the minimum RuboCop required version to
0.77.0

Fix: sds#107
tagliala added a commit to diowa/icare that referenced this issue Dec 3, 2019
Slim-lint does not support RuboCop 0.77.0

Ref: sds/slim-lint#107
tagliala added a commit to diowa/ruby2-rails5-bootstrap-heroku that referenced this issue Dec 3, 2019
Slim-lint does not support RuboCop 0.77.0

Ref: sds/slim-lint#107
@swrobel
Copy link

swrobel commented Dec 4, 2019

Layout/TrailingEmptyLines has been renamed to Layout/TrailingEmptyLines

@tagliala what's the issue exactly? Both strings above are identical...

@tagliala
Copy link
Contributor Author

tagliala commented Dec 4, 2019

@swrobel the issue is in my cut & paste. sorry

Layout/TrailingBlankLines has been renamed to Layout/TrailingEmptyLines

fixed

@sds sds closed this as completed in #109 Dec 10, 2019
sds pushed a commit that referenced this issue Dec 10, 2019
A lot of cops have been renamed since 0.50.0, this commit fixes the
default configuration and sets the minimum RuboCop required version to
0.77.0

Fix: #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants