Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stream ID regex to support '(' #209

Merged
merged 4 commits into from May 1, 2021
Merged

Update stream ID regex to support '(' #209

merged 4 commits into from May 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2021

According to Redis documentation, https://redis.io/topics/streams-intro, stream ID support a '(' prefix which causes the XRANGE command to be not inclusive.

@ghost
Copy link
Author

ghost commented Apr 29, 2021

Didn't look like there was a check for this anywhere because specs all still pass:

>bundle exec rspec
...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 1 minute 53.62 seconds (files took 1.37 seconds to load)
1019 examples, 0 failures

@ghost
Copy link
Author

ghost commented Apr 30, 2021

Actually implemented the exclusive range and added tests

@sds sds merged commit c129012 into sds:master May 1, 2021
@sds
Copy link
Owner

sds commented May 1, 2021

Thank you!

@sds sds added the enhancement label May 1, 2021
@ghost ghost deleted the master branch March 12, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants