change items.py to add float and int #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostming
reviewed
Jul 28, 2022
frostming
reviewed
Aug 1, 2022
Co-authored-by: Frost Ming <mianghong@gmail.com>
|
I add your commit @frostming |
Thanks. As a kind note about open source contribution, don't ping someone with @ but only click the resolve button when you are done with the change. It is a useless noise and will make people feel disturbed. |
|
Sorry i didn't know |
frostming
reviewed
Aug 1, 2022
|
Thanks for your contribution. |
capuanob
pushed a commit
to capuanob/tomlkit
that referenced
this pull request
Mar 1, 2023
* change items.py to add float and int * Update items.py * Update * Update tomlkit/items.py Co-authored-by: Frost Ming <mianghong@gmail.com> * run lint Co-authored-by: Frost Ming <mianghong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I change the add method for Integrer and add a test from this issue #214 now it's work but i don't know if you need this