Skip to content

Add Python 3.11 release candidate 2 to the testing #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 27, 2022
Merged

Add Python 3.11 release candidate 2 to the testing #239

merged 7 commits into from
Sep 27, 2022
+9 −3

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 17, 2022 •
edited
Loading

Python 3.11 will be on average 22% faster than Python 3.10 so let’s give it a spin... https://www.python.org/download/pre-releases

Related to #237

@cclauss
Add Python 3.11 release candidate 2 to the testing
b3d1286 
Python 3.11 will be on average 22% faster than Python 3.10 so let’s give it a spin...
https://www.python.org/download/pre-releases
frostming
frostming reviewed Sep 26, 2022
View reviewed changes
@cclauss
Copy link
Contributor Author

cclauss commented Sep 26, 2022

Successfully set up CPython (3.11.0-rc.2)

@cclauss
Copy link
Contributor Author

cclauss commented Sep 26, 2022

My sense is that supporting Python 3.11 using Poetry will require dropping Python 3.6 support.

@frostming
Copy link
Contributor

frostming commented Sep 26, 2022 •
edited
Loading

My sense is that supporting Python 3.11 using Poetry will require dropping Python 3.6 support.

True, that is why it was 1.15 before. Since tomlkit is a lower-level library, I prefer it to stay supporting 3.6 a bit longer. Dropping the support only because the testing infra isn't happy doesn't make sense to me. Can't we use 1.15 for now?

@cclauss
Copy link
Contributor Author

cclauss commented Sep 26, 2022 •
edited
Loading

Poetry is not test infra. Poetry is how the tomlkit is built.

  • https://devguide.python.org/versions
  • Python 3.11 is ~22% faster than 3.10 so there will be a lot of interest in migrating when it is released next week.
  • I have added mods so we can try to get both Py3.6 and Py3.11 to pass.

frostming
frostming reviewed Sep 26, 2022
View reviewed changes
@frostming frostming merged commit 611243e into python-poetry:master Sep 27, 2022
@frostming
Copy link
Contributor

LGTM!

@cclauss cclauss deleted the patch-1 branch September 27, 2022 05:27
capuanob pushed a commit to capuanob/tomlkit that referenced this pull request Mar 1, 2023
@cclauss
Add Python 3.11 release candidate 2 to the testing (python-poetry#239)
1effebf 
* Add Python 3.11 release candidate 2 to the testing

Python 3.11 will be on average 22% faster than Python 3.10 so let’s give it a spin...
https://www.python.org/download/pre-releases

* python-version: [3.6, 3.7, 3.8, 3.9, "3.10", "3.11.0-rc - 3.11"]

* Upgrade to Poetry v1.2.1

* strategy: fail-fast: false

* if: startsWith(matrix.python-version, '3.11')

* if: ! startsWith(matrix.python-version, '3.11')

* if: !startsWith(matrix.python-version, '3.11') # no space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cclauss @frostming