Switch manager tests to run on singleDC environment #7435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is an issue with multiDC cluster restore when the EaR is turned on (scylladb/scylla-manager#3829), it was decided to temporarily switch the main part of jobs to run on singleDC cluster. Only one multiDC cluster job is left for enterprise version 2022 where EaR is not implemented.
The test is valid only for multiDC configuration. Otherwise, it should be skipped.
4 tasks
fruch
reviewed
May 15, 2024
| @@ -5,9 +5,9 @@ def lib = library identifier: 'sct@snapshot', retriever: legacySCM(scm) | |||
|
|
|||
| managerPipeline( | |||
| backend: 'aws', | |||
| region: '''["us-east-1", "us-west-2"]''', | |||
| region: 'us-west-2', | |||
There was a problem hiding this comment.
it's on purpose you are putting each case on a different region ?
(if you can, you can even use random, I've fixed to be working a while back)
There was a problem hiding this comment.
I randomly chose one of the regions supported before in multiDC runs: "us-east-1" or "us-west-2"
There was a problem hiding this comment.
Just to explain, setting the region as random, can help a bit with the spot issues, since tests would spread to all of the supported regions, and won't all run on the exact same ones
fruch
reviewed
May 15, 2024
| @@ -349,9 +349,8 @@ def test_manager_sanity(self): | |||
| self.test_mgmt_cluster_crud() | |||
| with self.subTest('Mgmt cluster Health Check'): | |||
| self.test_mgmt_cluster_healthcheck() | |||
| # test_healthcheck_change_max_timeout requires a multi dc run. And since ipv6 cannot run in multi dc, this test | |||
There was a problem hiding this comment.
good that this comment is going away, cause the ipv6 part of it, is alway wrong. we can use ipv6 on AWS with multi-dc cases.
fruch
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes scylladb/scylla-manager#3850
Should be merged together with #7365
Since there is an issue with multiDC cluster restore when the EaR is turned on (scylladb/scylla-manager#3829), it was decided to:
After scylladb/scylla-manager#3829 resolution, multiDC cluster would be returned back.
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)