Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck shouldn't report error on missing status response #3847

Closed
karol-kokoszka opened this issue May 13, 2024 · 0 comments · Fixed by #3857
Closed

Healthcheck shouldn't report error on missing status response #3847

karol-kokoszka opened this issue May 13, 2024 · 0 comments · Fixed by #3857
Milestone

Comments

@karol-kokoszka
Copy link
Collaborator

karol-kokoszka commented May 13, 2024

As per title

client, err := r.scyllaClient(ctx, clusterID)
if err != nil {
return errors.Wrap(err, "get client")
}
status, err := client.Status(ctx)
if err != nil {
return errors.Wrap(err, "status")
}
live := status.Live()
r.removeMetricsForMissingHosts(clusterID, live)
r.checkHosts(ctx, clusterID, live)

Service should save the last live nodes and rely on them if it didn't manage to update this information.

@karol-kokoszka karol-kokoszka added this to the 3.2.8 milestone May 13, 2024
@karol-kokoszka karol-kokoszka changed the title Healthcheck cannot report error on missing status response Healthcheck shouldn't report error on missing status response May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant