-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(group_common_events): filter expected raft_topology error messages #7452
fix(group_common_events): filter expected raft_topology error messages #7452
Conversation
0901c2b
to
c420ec1
Compare
@aleksbykov do we have anywhere confirmation/agreement from devs about ignoring those ? To make sure we are not overlooking actual issues ? |
Yes, these errors are expected during when operation has been aborted. Similar we have and for dtest. Dev approved them. |
Don't we wish to capture the narrow scope of the error? Example:
I wish to catch an exception with this specific reason - 'node state is rebuilding' - not just any failure of send raft_topology_cmd exception, no? |
5fbada9
to
43b9a6e
Compare
@mykaul , i wanted to have wider regexp to filter out possible errors during operations. But you right, i rewrote error regexp to be more specific, so not to loose possible issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to fix commit message (too long line)
otherwise, when you confirm it works as expected (after fixes),
LGTM
@soyacz the extra fix here for the remoter logger should come on it's own and get backport together with the original PR introduced it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But first address the failures in pre commit checks
43b9a6e
to
a9b22f3
Compare
a9b22f3
to
462f1b2
Compare
Job passed with the fix: https://jenkins.scylladb.com/job/scylla-staging/job/abykov/job/longevity-twcs-4h-staging-test/21 |
Add common group_events context manager which will Change severity of expected error log messages to warning when topology operations is failed aborted by request Fixes: scylladb#7426, scylladb#7425
462f1b2
to
52f5e66
Compare
@fruch are we backporting manually or with mergify? |
backported manually for now. |
we can do any of the above, mergify is just a bit more safe, and documented process. |
Raft topology features bring new error messages, which could appear in logs when any topology operation aborted/failed.
Add common_group_events context manager which will Change event severity of expected error log messages from error to warning when topology operations is failed
Fixes: #7426, #7425
Testing
PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)