Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy installation fails #94

Closed
LucaMarconato opened this issue Jan 4, 2023 · 4 comments
Closed

mypy installation fails #94

LucaMarconato opened this issue Jan 4, 2023 · 4 comments
Labels
bug Something isn't working CI Related to Continuous Integration dev process Only affects the devs

Comments

@LucaMarconato
Copy link
Member

Mypy checks pass offline, but the github action fails because the env can't be found.
I'll still merge two prs that have been approved to main, the red mark being due to this issue.
Screenshot 2023-01-04 at 17 15 17

@ivirshup
Copy link
Member

ivirshup commented Jan 9, 2023

@LucaMarconato it looks like it's just timing out. It seems odd to me that just installation would time out.

I can't replicate installation taking anywhere near as long on my machine, so couldn't guess what's up.

Re your comment on zulip, not clear to me that this is mypy, I think we're only seeing a few lines of the log.

@ivirshup ivirshup added bug Something isn't working CI Related to Continuous Integration dev process Only affects the devs labels Jan 9, 2023
@ivirshup
Copy link
Member

ivirshup commented Jan 9, 2023

Hmm, maybe the log is meant to be mypy specific (pre-commit-ci/issues#33)? Not sure how pre-commit ci actually runs. If it's mypy we could just move mypy out to a separate CI action, since I don't think it would ever modify the code itself – the main benefit of the pre-commit CI service.

@LucaMarconato
Copy link
Member Author

Thanks, I removed mypy from the CI as shown here. I also had to update the link to the badge because it was broken. Now it seems to work.

@LucaMarconato
Copy link
Member Author

Maybe the changes could be included in the cookie cutter. Not sure why the url of the badge changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Related to Continuous Integration dev process Only affects the devs
Projects
None yet
Development

No branches or pull requests

2 participants