Skip to content

Make suggestions work with tippy.js v6 #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2020
Merged

Make suggestions work with tippy.js v6 #655

merged 3 commits into from
Apr 10, 2020
+37 −44

Conversation

gambolputty
Copy link
Contributor

@gambolputty gambolputty commented Apr 5, 2020 •
edited
Loading

This PR:

  • updates tippy.js dendency to version 6
  • provides updated example code for the suggestion/mention extension

As pointed out in #523:

The new API of tippy.js does not have instance.popperInstance.scheduleUpdate method anymore.

So we use the proposed sticky plugin to make tippy.js update itself, when content changes.

@gambolputty gambolputty marked this pull request as ready for review April 5, 2020 12:56
@gambolputty gambolputty mentioned this pull request Apr 5, 2020
Closed
@philippkuehn
Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
99bf58e
@philippkuehn philippkuehn merged commit 1757965 into ueberdosis:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gambolputty @philippkuehn