Skip to content

Floating Menu doesn't receive isActive on initial focus #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackmcdade opened this issue Jun 8, 2019 · 2 comments
Closed

Floating Menu doesn't receive isActive on initial focus #347

jackmcdade opened this issue Jun 8, 2019 · 2 comments
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@jackmcdade
Copy link

Describe the bug
If your editor is empty (e.g. starting a new document), focusing the editor will not open the floating menu. You need to enter a character and backspace to trigger isActive and pop it open.

Steps to Reproduce / Codesandbox Example
Steps to reproduce the behavior:

  1. Go to https://tiptap.scrumpy.io/floating-menu
  2. Delete the content
  3. Blur out of the field
  4. Focus the field - no floating menu (there should be)
  5. Enter a character and backspace
  6. Floating menu shows.

Fork this or create a new Codesandbox replicating your error
https://codesandbox.io/s/qxv5m9y6oq?fontsize=14

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • OS: MacOS latest
  • Browser Chrome latest
  • Mobile / Desktop: Desktop

Additional context
Add any other context about the problem here.

@philippkuehn
Copy link
Contributor

Should be fixed in tiptap@1.22.1

@jackmcdade
Copy link
Author

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants