Diff with the current geth codebase's vm.interpreter.Run function

[hsyodyssey]

Hi, just found that our EVM's interpreter's Run function is a bit different than the current codebase of Geth. In order to improve performance, they removed the code in this place that https://github.com/scroll-tech/go-ethereum/blob/zkrollup/core/vm/interpreter.go#L183-L188. (Current Geth: https://github.com/ethereum/go-ethereum/blob/master/core/vm/interpreter.go#L181-L185)

Since this part is the core function of EVM, maybe we should align with them in the next release?

FYI:

• Redesign async EVM termination ethereum/go-ethereum#23969
• core/vm: Move interprepreter intrerruption check to jump instructions ethereum/go-ethereum#24026

[lispc]

I am not sure whether this commit only improves performance, or change the "interface".

PR like this one ethereum#24867 changes the "interface" (or changes behavior of API) of tracing. We may have to upgrade both zkevm-circuits to handle this change AND rebase the diff into this l2geth repo at the same time later.

But if a commit only improves performance but does not change the API input/output, we don't need to apply the diff urgently.

[hsyodyssey]

It looks like they moved some of the logic to the instruction level. I'm not that familiar with circuit design, so maybe you can see if the opJump and opJumpi instructions have had an impact on the current circuit design.

• https://github.com/ethereum/go-ethereum/blob/440c9fcf75d9d5383b72646a65d5e21fa7ab6a26/core/vm/instructions.go#L535-L538
• https://github.com/ethereum/go-ethereum/blob/440c9fcf75d9d5383b72646a65d5e21fa7ab6a26/core/vm/instructions.go#L547-L550

They have merged this pr to 1.10.14. It looks like we are using 1.10.13. which is only a minor release away😂.