Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrapy gunzip inclusion? #43

Open
nyov opened this issue Feb 26, 2016 · 1 comment
Open

scrapy gunzip inclusion? #43

nyov opened this issue Feb 26, 2016 · 1 comment
Labels
discuss enhancement

Comments

@nyov
Copy link
Contributor

nyov commented Feb 26, 2016

Would scrapy's gunzip and is_gzipped functions (scrapy/utils/gz.py) fit in w3lib?
If is_gzipped would take headers instead of response as argument, there is no other dependency.
@Gallaecio
Copy link
Member

Gallaecio commented Apr 2, 2019 •
edited

I’ve just proposed to deprecate is_gzipped in Scrapy: scrapy/scrapy#3718

Maybe we could implement Scrapy’s gzip_magic_number as is_gzipped here?

As for gunzip, it may make sense to move it to w3lib. I think it would become the easiest answer for https://stackoverflow.com/q/1732709/939364

@redapple, @dangra, @kmike Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nyov @Gallaecio