From 5c916bebe84aa08f3ca5bcedb685451fd737d6f4 Mon Sep 17 00:00:00 2001 From: Renne Rocha Date: Mon, 29 Jul 2019 19:07:34 -0300 Subject: [PATCH] Added constrain on lxml version based on Python version --- requirements-py3.txt | 3 ++- setup.py | 3 ++- tests/constraints.txt | 3 +-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/requirements-py3.txt b/requirements-py3.txt index 5a5d4c95af4..478ed0010dd 100644 --- a/requirements-py3.txt +++ b/requirements-py3.txt @@ -1,5 +1,6 @@ Twisted>=17.9.0 -lxml>=3.2.4 +lxml;python_version!="3.4" +lxml<=4.3.5;python_version=="3.4" pyOpenSSL>=0.13.1 cssselect>=0.9 queuelib>=1.1.1 diff --git a/setup.py b/setup.py index 4dc6d18c165..ee0aaabf0aa 100644 --- a/setup.py +++ b/setup.py @@ -69,7 +69,8 @@ def has_environment_marker_platform_impl_support(): 'Twisted>=13.1.0,<=19.2.0;python_version=="3.4"', 'w3lib>=1.17.0', 'queuelib', - 'lxml', + 'lxml;python_version!="3.4"', + 'lxml<=4.3.5;python_version=="3.4"', 'pyOpenSSL', 'cssselect>=0.9', 'six>=1.5.2', diff --git a/tests/constraints.txt b/tests/constraints.txt index e59e68b3f20..5655ac2d374 100644 --- a/tests/constraints.txt +++ b/tests/constraints.txt @@ -1,2 +1 @@ -Twisted!=18.4.0 -lxml!=4.2.2 \ No newline at end of file +Twisted!=18.4.0 \ No newline at end of file