Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 6047 #6176

Closed
wants to merge 7 commits into from
Closed

Fix for issue 6047 #6176

wants to merge 7 commits into from

Conversation

phyllis-feng
Copy link

@phyllis-feng phyllis-feng commented Dec 10, 2023 •
edited

Added errbacks by rewriting crawl() functoins

Still in progress

To Do:

  • fix typing errors
  • add more documentation

Fixes #6047

sa2415 and others added 6 commits November 30, 2023 20:26
@sa2415
Update misc.py
1ada3aa 
Attempted build_from_crawler
@monicaq21
Revert "SPM → Zyte API (scrapy#6163)"
65b2b24 
This reverts commit 70ba3a0.
@monicaq21
Revert "Update misc.py"
c81c6bd 
This reverts commit 1ada3aa.
@monicaq21
Revert "Revert "SPM → Zyte API (scrapy#6163)""
b140e0d 
This reverts commit 65b2b24.
@phyllis-feng
Update crawler.py
b53e0fe 
reformats first crawl() function try-except and adds errback
@sa2415
Need to fix 3 typing errors - all other tests pass
b5bf11a
@phyllis-feng phyllis-feng marked this pull request as draft December 10, 2023 20:32
@wRAR
Copy link
Member

wRAR commented Feb 28, 2024

Is this still in progress?

@wRAR wRAR closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve unhandled exception handling for Crawler*.crawl()
4 participants
@phyllis-feng @wRAR @sa2415 @monicaq21