Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TWISTED_REACTOR in the default template. #5679

Merged
merged 2 commits into from Oct 15, 2022

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Oct 14, 2022

Fixes #5590

@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #5679 (75bb516) into master (715c05d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5679      +/-   ##
==========================================
- Coverage   88.67%   88.64%   -0.03%     
==========================================
  Files         162      162              
  Lines       10966    10975       +9     
  Branches     1796     1796              
==========================================
+ Hits         9724     9729       +5     
- Misses        961      966       +5     
+ Partials      281      280       -1     
Impacted Files Coverage Δ
scrapy/commands/parse.py 28.19% <0.00%> (+0.25%) ⬆️
scrapy/core/downloader/__init__.py 92.48% <0.00%> (+1.50%) ⬆️

@wRAR wRAR merged commit ea6315b into scrapy:master Oct 15, 2022
@wRAR wRAR deleted the template-asyncio-reactor branch October 15, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make asyncio reactor a default
2 participants